On Sat, 2009-10-03 at 12:43 +0100, Richard Hughes wrote:
attached is a fix for bug 402274. It's trivial and I cannot imagine it causing any problems but I'd be glad if someone could take a quick look anyway in case I overlooked something.
I'm not sure. I think that patch might re-order text in some cases, although I haven't tried to come up with an example where it would. Attached is a version that I think is more correct.
Okay, it no longer crashes. However, if you select a portion of the text in that example file from the report so that it crosses the different styles and change font size or the font, it seems to strip the style from the unselected black text. Any chance for a better fix?
Note, the above behavior is not the same if I create a new tspan and try to reproduce it... so I do feel comfortable committing it, but if there's hope for an even more improved one I would rather wait on that.
Cheers, Josh