Hi,
I am looking through the inkscape codebase trying to understand how things work, and I thought it would be good to do some "janitorial" work. Below are patches for the files in the src/application directory that mainly clean up some very minor typos.
In addition, I have changed the vim modelines to have filetype of "cpp" rather than "c++" because the default install of vim uses cpp. If there is a standard inkscape policy to use "c++" instead, I can remove this. If there is not such a policy, then really all the cpp files should have a vim modeline using the cpp filetype. I could also submit a diff for this.
I have also stripped a declaration for the Inkscape::XML namespace that does not appear to be used in application.cpp, but I am less sure about this.
Thanks for your consideration,
-Mason Thomas
Index: application.cpp =================================================================== RCS file: /cvsroot/inkscape/inkscape/src/application/application.cpp,v retrieving revision 1.9 diff -u -p -r1.9 application.cpp --- application.cpp 9 May 2005 04:44:55 -0000 1.9 +++ application.cpp 1 Nov 2005 06:17:27 -0000 @@ -10,7 +10,7 @@ */
#ifdef HAVE_CONFIG_H -# include <config.h> +#include <config.h> #endif
#include <gtkmm/main.h> @@ -26,12 +26,6 @@ int sp_main_console(int argc, char const namespace Inkscape { namespace NSApplication {
-namespace Inkscape { -namespace XML { -class Document; -} -} - class GSList;
Application::Application(int argc, char **argv, bool use_gui, bool new_gui) @@ -169,4 +163,4 @@ Application::exit() fill-column:75 End: */ -// vim: filetype=c++:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 : +// vim: filetype=cpp:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 :
Index: application.h =================================================================== RCS file: /cvsroot/inkscape/inkscape/src/application/application.h,v retrieving revision 1.4 diff -u -p -r1.4 application.h --- application.h 9 May 2005 04:44:55 -0000 1.4 +++ application.h 1 Nov 2005 06:17:38 -0000 @@ -59,7 +59,7 @@ protected: } // namespace NSApplication } // namespace Inkscape
-#endif // INKSCAPE_APPLICATION_EDITOR_H +#endif // INKSCAPE_APPLICATION_APPLICATION_H
/* Local Variables: @@ -70,4 +70,4 @@ protected: fill-column:99 End: */ -// vim: filetype=c++:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 : +// vim: filetype=cpp:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 :
Index: editor.cpp =================================================================== RCS file: /cvsroot/inkscape/inkscape/src/application/editor.cpp,v retrieving revision 1.7 diff -u -p -r1.7 editor.cpp --- editor.cpp 9 May 2005 04:44:55 -0000 1.7 +++ editor.cpp 1 Nov 2005 06:17:50 -0000 @@ -13,7 +13,7 @@ */
#ifdef HAVE_CONFIG_H -# include <config.h> +#include <config.h> #endif
/* @@ -207,4 +207,4 @@ Editor::exit() fill-column:99 End: */ -// vim: filetype=c++:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 : +// vim: filetype=cpp:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 :
Index: editor.h =================================================================== RCS file: /cvsroot/inkscape/inkscape/src/application/editor.h,v retrieving revision 1.7 diff -u -p -r1.7 editor.h --- editor.h 9 May 2005 04:44:55 -0000 1.7 +++ editor.h 1 Nov 2005 06:18:00 -0000 @@ -95,4 +95,4 @@ protected: fill-column:99 End: */ -// vim: filetype=c++:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 : +// vim: filetype=cpp:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 :
Index: app-prototype.cpp =================================================================== RCS file: /cvsroot/inkscape/inkscape/src/application/app-prototype.cpp,v retrieving revision 1.1 diff -u -p -r1.1 app-prototype.cpp --- app-prototype.cpp 5 Mar 2005 20:51:51 -0000 1.1 +++ app-prototype.cpp 1 Nov 2005 06:16:57 -0000 @@ -39,4 +39,4 @@ AppPrototype::~AppPrototype() fill-column:75 End: */ -// vim: filetype=c++:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 : +// vim: filetype=cpp:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 :
Index: app-prototype.h =================================================================== RCS file: /cvsroot/inkscape/inkscape/src/application/app-prototype.h,v retrieving revision 1.3 diff -u -p -r1.3 app-prototype.h --- app-prototype.h 5 Mar 2005 20:51:51 -0000 1.3 +++ app-prototype.h 1 Nov 2005 06:17:07 -0000 @@ -38,7 +38,7 @@ protected: } // namespace NSApplication } // namespace Inkscape
-#endif // INKSCAPE_APPLICATION_EDITOR_H +#endif // INKSCAPE_APPLICATION_APP_PROTOTYPE_H
/* Local Variables: @@ -49,4 +49,4 @@ protected: fill-column:75 End: */ -// vim: filetype=c++:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 : +// vim: filetype=cpp:expandtab:shiftwidth=4:tabstop=8:softtabstop=4 :