On Apr 16, 2011, at 12:58 PM, Johan Engelen wrote:
On 16-4-2011 18:17, Jon Cruz wrote:
On Apr 16, 2011, at 6:04 AM, Johan Engelen wrote:
I stick to the commit message of r10168.
The C code is very verbose, difficult to read, and no fun to maintain. Especially subclassing is terrible in C-style, and I guess this is why there is so much duplicate code to be found in the UI: nobody can re-use widgets from other parts.
In all C++ dialogs/widgets it is easy to add the extra functionality, and I will do it. In all C code, I will not.
Yes, but the big problem is that you are looking at *shared* code, not Inkscape-only code.
Shared with which other projects? It is nice that we benefit by this sharing, and as such, I see that the code is updated very regularly from improvements by the other sharing projects.
Yes, it is. Since it is mainly from other projects I have going.
Thanks for the kudos.
As Krzysztof noted looking into the GSoC C++-ification project, much of the code being changed was extremely similar in C++ as in C, with mainly the long function names being changed to class::member declarations, etc.
I think Krzysztof's comments about the GSoC C++-ification were meant as a disappointment (which I share). C++-ification does not mean changing functions to class::member stuff. It means, for example, getting rid of elaborate code to get polymorphism and virtual functions in C-style, by using C++ classes and virtual functions.
Some, but not all. However *MORE* important is getting proper encapsulation and modularity.
Just in doing that we have found many subtle bugs in our code. C-style casts are one of the worst offenders.
I suppose the added functionality in Inkscape is not worth "breaking" the "sharing of code" that changes approximately once every year. Upon reverting, please add your arguments to the 5+ wishlist reports on Launchpad for math expression support in input fields, and mark them as "won't fix".
Sorry for the lack of updates, but nobody has been pointing any of those out to me.
Also, I've been quite busy with several things, including helping out a friend who's funeral and memorial are taking me away from Inkscape work today. sorry for the inconvenience to you.