Quoting bulia byak <buliabyak@...400...>:
On Mon, 31 Jan 2005 13:44:51 -0500, mental@...3... <mental@...3...> wrote:
Quoting bulia byak <buliabyak@...400...>:
Well, though the function is mine, I didn't write this comparison, but copied it from somewhere. If you fix it I'll copy the correct idiom next time :)
The correct idiom, provided I had done things properly on my end, would be
no
cast at all. The compiler ought to be aware that SPCSSRepr ISA SPRepr.
does not work:
desktop-style.cpp: In function `SPCSSAttr* sp_desktop_get_style(SPDesktop*, bool)': desktop-style.cpp:166: error: invalid use of undefined type `struct SPCSSAttr' xml/xml-forward.h:6: error: forward declaration of `struct SPCSSAttr'
Well, you would still need to make a couple minor cleanups. The forward declaration in xml/xml-forward.h is (I think) unnecessary (actually the whole file is unnecessary and a bad idea, but I will rant about that separately).
I think I'm going to go ahead and redo the Repr CSS stuff the right way tonight though.
-mental