W dniu 28 lipca 2010 06:52 użytkownik bulia byak <buliabyak@...400...> napisał:
I don't see any necessity for dynamic generation of keys, and doing a string dup on each undo event sounds unnecessarily wasteful.
~50 bytes of extra memory consumption per document looks like a reasonable price to pay to fix undo in the filter dialog, and possible future places that will need to use dynamic generation of undo keys. It's also much lower than the memory required to store all the static strings. Only the last undo key is stored.
In any case, this is a nontrivial change in a very sensitive area, so I would prefer to err on the side of caution and not apply it to 0.48, given that the problem it fixes is relatively cosmetic.
The change is safe, because we are enlarging the valid domain of arguments, not shrinking it.
Regards, Krzysztof