
On 11-Feb-2014 06:00, Tavmjong Bah wrote:
'preserveAspectRatio' is now set to 'none'; r13023.
Just tried 13024 and on import of images from EMF preserveAspectRatio is not set automatically. When you say it is set to 'none' now in what context does that apply? It isn't a problem adding
preserveAspectRatio="none"
to the SVG <image> creation in EMF and WMF, but before doing so, I want to double check that it is not supposed to be happening elsewhere automatically. Presumably a similar line will need to be added to every other file format's image input conversion if it is not to be handled in some central location.
Also, regarding bug 1278645, setting the above line in the <image> fixes the EMF/WMF image output. Which tells us that the default value for preserveAspectRatio is doing something wrong for the one image in the test case. That test is from start to finish just a (10,10) bitmap, but for some reason it gets trimmed down to a (5,5) in SPImage::print in sp-image.cpp in the default case, but stays (10,10) for "none".
Putting that preserveAspectRatio in the <svg> at the top of the file does NOT resolve the EMF/WMF image output issue, it has to be in (each) <image>. Is that right - or should the <image> inherit its preserveAspectRatio from the <svg> within which it resides?
preserveAspectRatio applies to:
<svg> <symbol> <image> <feimage> <marker> <pattern> <view>
are we going to have similar issues with any of these?
Regards,
David Mathog mathog@...1176... Manager, Sequence Analysis Facility, Biology Division, Caltech