-----Original Message----- From: Bryce Harrington [mailto:bryce@...1798...] Sent: vrijdag 22 februari 2008 3:07 To: Maximilian Albert Cc: Engelen, J.B.C. (Johan); inkscape-devel@lists.sourceforge.net; theadib@...1439... Subject: Re: [Inkscape-devel] crash on pdf/ps export
On Fri, Feb 22, 2008 at 01:36:19AM +0100, Maximilian Albert wrote:
J.B.C.Engelen@...1578... schrieb:
Heh, I just fixed this aswell last evening, but didn't
have internet.
I had the exact same fix :-)
Sometimes I wonder whether NULL pointer tests really solve these issues in all cases or if they sometimes just cover other
underlying
bugs (maybe the very fact that a NULL pointer is passed is wrong?). But in this case the fix seems to work fine; at least my exported pdf/ps files look good. :)
However, the crash unfortunately still occurs when one
presses "Close"
instead of "OK" in the pdf/ps options dialog which appears
after the
"Save file" dialog.
It's fairly traditional to use a NULL pointer to mean "not defined", so NULL pointer checks are quite standard and commonly used for controlling when certian logic should be invoked.
True, but in this case, I'm wondering whether it is better to do the check somewhere else. The function that tests for this NULL does nothing if it is NULL. Since it is a callback function (correct?) that is a reaction on pressing the OK button, maybe this shouldn't have been set as such in the first place.
I'll try to have a look into the other crash.
Johan