Re: [Inkscape-devel] new website: coding style

On Tue, Sep 17, 2013 at 2:27 AM, Johan Engelen <jbc.engelen@...2592...> wrote:

Hi all, There are some errors in the coding style page I believe. Two big issues:

 namespace  Inkscape  {
 namespace  UI  {
 Sandwich  make_sandwich(int  x);
 int  make_a_mess(float  y);
 }
 }

instead of

 namespace  Inkscape  {
 namespace  UI  {
     Sandwich  make_sandwich(int  x);
     int  make_a_mess(float  y);
 }
 }

Changed this.

For these kind of forward declarations, I think it is much clearer to indent. Not for class definitions etc.

And

 switch  (a)  {
     case  1:
     do_one();
     break;

instead of

 switch  (a)  {
     case  1: {
         do_one();
         break;
     }
     ...
     default:
         break;
 }

Because the code already has unindented code after the "case:", I assume you meant the opposite. Is this correct?

i.e

case 1: foo(); bar();

instead of:

case 1: foo(); bar();