-----Original Message----- From: Marco [mailto:mrcekets@...400...] Sent: maandag 28 april 2008 12:07 To: bulia byak; Engelen, J.B.C. (Johan); MenTaLguY Cc: inkscape-devel@lists.sourceforge.net; lib2geom-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] [Lib2geom-devel] newSVGEllipticalArcimplementation merged intopath.h
On Mon, 28 Apr 2008 03:45:36 +0200, bulia byak <buliabyak@...400...> wrote:
On Sun, Apr 13, 2008 at 4:29 PM,
<J.B.C.Engelen@...1578...> wrote:
I think right now I can remove an error message in
Inkscape=>2geom
conversion when a path contains an 'A' description. Can't remember exactly, but will check soon. Thanks!!!
Before, pattern on path failed for ellipse pattern - now it
crashes with:
inkscape: 2geom/svg-elliptical-arc.cpp:128: void Geom::SVGEllipticalArc::calculate_center_and_extreme_angles(): Assertion `-1 < arg && arg < 1' failed.
Emergency save activated!
This assertion is raised when the parameter passed to the SVGEllipticalArc constructor can't be used to create an elliptical arc. That is, given the x and y rays, the rotation angle and the initial and final points there is no ellipse that satisfies all together such constraints and so it's not possible to build an elliptical arc with the passed data. Would you like to manage such case by throwing an exception or by quietly setting a boolean flag that will have to be tested after each elliptical arc instantiation ?
I think it's best when you change the assertion to throwing an exception (see exception.h for some macros). However, I think it is best if we add some sort of debug flag so that people can choose between throwing an exception or doing an assert (crash). Inkscape release should have exceptions, Inkscape devel should have crashes. That way we won't stop thinking about fixing the bugs, and also have a more stable release version. I'll have a look and change the exception.h macros according to this, so please use them :)
Kind regards, Johan