On 2013-09-18 23:07 +0200, Guillermo Espertino (Gez) wrote:
El 18/09/13 16:27, Martin Owens escribió:
Hey Devs,
I've just committed a fix for that darn disappearing text and other items. The culprit was a blank _item_bbox, the code for _item_bbox was very sparse and looking back to the history of where it comes from shows that Niko Kiirala introduced it back in r3505 (2007) to improve filter effect handling when transformed.
What I've done is stripped it out and replaced it with the _bbox used for all the other operations. This means the bounds for the filtering process won't be different for the bounds during other parts of the process. See revision 12528 for the gory details.
What I should be sure of is what Niko was trying to do and if Ted Gould (r6891) or Krzysztof Kosiński (r10347.1.21) spotted anything as they were refactoring the code.
Please do test trunk for issues surrounding filters and transforms. I'd like to make sure fixing this issue doesn't introduce another.
Best Regards, Martin Owens
After a really quick inspection, everything seems ok. The disappearing blurred text bug is gone, and that alone makes me happy :) The filtered objects don't get dark when transformed anymore. Not sure if it was your fix too. was it?
However, I found something that I'm not sure related to this commit (I can't tell because I didn't try before, please take a look): some of the filters don't work properly. The easiest way to check is to apply a drop shadow filter to a text. It does nothing, although the bounding box changes its dimensions.
Some findings with recent builds:
r12525: feFlood still works, but the size of the actually used FER has changed (there is now a gap between visual bbox frame and filled area from feFlood, or other filter primitives like e.g. feTurbulance) r12528: feFlood no longer fills the FER with a visible color (this breaks effects like e.g. Drop Shadow, see Gez's report)
r12525: Inkscape crashes on load of this file (r12524 is ok): http://www.w3.org/TR/SVG11/images/filters/enable-background-01.svg reference image: http://www.w3.org/TR/SVG11/images/filters/enable-background-01.png source: http://www.w3.org/TR/SVG11/filters.html#AccessingBackgroundImage
r12525: breaks FER position and size: While trying to figure out the current relationship between FER, visual bounding box (and stroke with), I came across another regression in the filter editor: Changing coordinates and/or dimensions in the filter editor does not live-update the filter output area (it only affects the position and size of the visual bbox frame). This seems to have started with the changes in r12362 (in tests with archived builds it works as expected with r12359, in r12364 and later revisions one has to force a refresh or reload the file to see the FER updated), and regressed one more step in r12525 (now AFAICT the FER neither is correctly updated when forcing a refresh nor when reloading the file).