On 1-11-2013 15:40, Krzysztof Kosiński wrote:
AlwaysBreakTemplateDeclarations: false
I think this should be true (e.g. the template parameters should always be on their own line)
BreakConstructorInitializersBeforeComma: false
This should also be true - if I get it right, setting this to true will give us a Boost-like initializer list (as seen in 2Geom), which is easier to maintain.
ConstructorInitializerAllOnOneLineOrOnePerLine: false
This also sounds like it should be true.
MaxEmptyLinesToKeep: 1
I would set this to 2 or even 3.
Thanks, I'll try the changes.
Otherwise the file looks OK. I would rename it to "clangformatrc", in parallel to the astylerc we already have.
The file has to be named .clang-format or _clang-format, the filename is hardcoded (clang-format automatically searches parent folders of the src file).
Once we get this pretty-printing correct, we no longer need a page on code layouting, as we can simply point to the program to use to pretty-print new code. I hope this keeps our code clean and prevents confusions/discussions.
regards, Johan