May i suggest to only refactor as much as really needed to close the bugs that are open.
Wasn't there this discussion about to use export and import dialogues for non svg file formats where is a potential loss of information and to use open and save only for svg. ... Adib.
On Sun, Aug 9, 2009 at 6:56 PM, Maximilian Albert<maximilian.albert@...1439...> wrote:
2009/8/9 bulia byak <buliabyak@...400...>:
Yes, right. I got a bit confused from reading the code. :-) I didn't know that there are two types of export dialogs, one of which mimicks the regular Save dialog and is deactivated by default. I have never tried it anyway. Does it work and does anyone use it?
The save-like dialog is for vector output, the "other" one is for bitmap export (ctrl+shift+e).
I'm not sure if I understand which dialog you're referring to because it sounds like the one you're describing is in regular use. I'm talking about the one which is defined in ui/dialog/filedialog.cpp starting from line #240 (as of rev. 22036) and which has #ifdefs around it. Anyway, I just tried it and it's apparently not currently used since Inkscape didn't even compile when I uncommented #define NEW_EXPORT_DIALOG. :-P
Now I put the whole code which refers to this dialog between #ifdef's and fixed the build when NEW_EXPORT_DIALOG is defined. However, the dialog crashes when trying to export any file. I'm wondering if it can be scrapped completely since it's apparently not in use and doesn't seem to have been touched since revision 12671. Any opinions?
Max
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel