3 Aug
2005
3 Aug
'05
5:56 p.m.
Quoting bulia byak <buliabyak@...400...>:
* src/gc-alloc.h: backport fix for improper allocationsize
Just curious - is this safe/important enough? Any memory leaks patched by this?
Memory leak? No, it was a potential crash bug. I'd misunderstood STL's memory allocation interface, so I was only allocating ( size ) bytes instead of the expected ( size * sizeof(T) ) bytes.
However, since GC::Alloc is not a normal part of GC allocation (just an adaptor for STL), only a small portion of the codebase was affected.
Breakdown:
Severity of Bug: CRITICAL [guaranteed buffer overruns] Likelihood of Occurence: LOW [rarely-used code] Risk of Fix: MINIMAL [simple, obviously correct fix]
-mental