On 06/11/2017 04:51 PM, Michael Soegtrop via Inkscape-devel wrote:
Dear Bryce,
Also, in general, I know we've been apt to pull stuff into the main codebase but going forward as much as possible let's try to keep external dependencies completely external, with detection logic in cmake. The more we can slim down the codebase the easier it'll be for new folks to learn and less work it'll be for busy old timers to maintain over the long run.
The piece I suggested is exactly that: cmake code which detects and implements sanitizer support. But it is just 10 or so cmake files and can also be copied.
Another solution here would be to have the CI job that did the sanitizer check download the CMake files on the fly from another source. This way we wouldn't have to have them in our repo at all, just when the job is run. We should save them as an artifact of that job for debugging though.
Ted