On 2013-07-31 21:05 +0200, Markus Engel wrote:
Okay, I'll fix that now... I know that there is still some things left to do, e. g. turning some methods into member methods. But actually, I didn't notice any obvious bugs and keeping all the work in a separate branch gets quite difficult for me when there are so many people making changes to the files I modified. I will of course further refactor the classes I started with :) .
JFYI - compiling your branch with Apple clang 3.1 on OS X 10.7.5 results in lots of warnings about mismatched tags (852 with r11718), for example:
In file included from ../../src/box3d.cpp:24: In file included from ../../src/box3d-context.h:20: ../../src/event-context.h:102:1: warning: 'SPEventContext' defined as a class here but previously declared as a struct [-Wmismatched-tags] class SPEventContext { ^ ../../src/event-context.h:26:1: note: did you mean class here? struct SPEventContext; ^~~~~~ class
Inkscape trunk used to have lots of these warnings too, once basic clang support was available - see comment #33 ff in https://bugs.launchpad.net/inkscape/+bug/992124
Attached is a list of the warnings (grepped for 'Wmismatched-tags').