On Mon, Mar 24, 2008 at 06:19:14PM -0500, Aaron Spike wrote:
Thanks, Bryce. And thanks to everybody who put in the long hours to resolve these issues.
Bryce Harrington wrote:
I've also written a simple script to apply the patches:
cd /packaging/win32/ && ./apply_patches.sh
Shell script for applying windows patches. Hehe. I wonder if there is a slightly less humorous method for applying patch sets on windows. As long as there is a small number of patches they can be easily applied using TortoiseSVN.
Yeah, call it a proof of concept. Basically it just foreach's the contents of the series files, applies each patch in turn, and prints out a friendly status list at the end. Could likely be reimplemented in any scripting language without breaking a sweat.
The key thing is enabling a system for storing and managing windows patches separate from the main code. The philosophy here (used by debian, redhat, and other distros) is to keep the original tarball "pristine", and all distro/platform specific patches independent.
As it turns out, it's good that I did this - the windows printing patch in fact causes failure to build on Linux. Seems to be depending on the existance of FontFactory.h.
Anyway, I hope the window package can be generated and posted ASAP. We'll be putting out the PR probably this evening, and it would be nice to have the windows .exe's posted by then. (The earlier the better, to give folks time to test.)
Bryce