On Sun, Nov 23, 2014, at 02:38 PM, Johan Engelen wrote:
Hi Jabier, I just discovered that you added a "default unit" to LivePathEffect::Effect class. Unfortunately, we will have to remove that, or at least make a drastic change there.
A LivePathEffect is meant to be a purely mathematical function, that depends as little as possible on the rest of Inkscape. To work with units, one would have to know the full item2document transform times the SVG units used, and use that in the effect calculation. I'm really not sure if we should do this.
What the code is doing now is wrong if an item has a transform applied to it.
FYI, I had spotted a few things about changes where UI specifics (desktop, etc) seemed to have been crossing improperly into the LPE code. Jabier and I were just starting to sort some of this out. The aspect of units and transforms that Johan spotted is just one manifestation of the meta-issue.
We probably need to check to keep LPEs clean and move any more UI centric work elsewhere.