On Wed, 2014-03-12 at 07:54 -0700, LucaDC wrote:
My sentence was a provocation to say that existing commits are not always good, sometimes you need to modify also what others have done to fit it with your work. Or do you think that you should never touch what others have written? If so you could only add code and it's pretty hard to correct bugs in this way... ;)
It depends how long ago the commit was. If we're talking months, then consider the code settled and change it as needed to fix issues.
On the other hand, if it's a recent commit, please contact the committer before reverting. I don't mean things like spelling mistakes or correcting make files or the like. But functional changes.
Maybe they forgot to put in a comment that explains things or maybe they're right. A discussion here on the list would unpick the different perspectives if needed.
But the first thought I think is for us to think of other developers as being competent first and then as us all as human, so mistakes will be made. But they can be cleared up by talking first.
Martin,