:) Actually, clang has already output this warning a year ago, but I never managed to look into this... gcc did never complain. You should probably get a few different environments (clang with -Weverything ;)) so you can fix even more warnings...
In many places I'm just not sure whether these things are intended. Let's say ../../trunk/src/live_effects/lpe-powerstroke.cpp:611:104: warning: implicit conversion from 'double' to 'bool' changes value from 0.01 to false [-Wliteral-conversion] Geom::Path fixed_path = path_from_piecewise_fix_cusps( pwd2_out, y, jointype, miter_limit, LPE_CONVERSION_TOLERANCE);
#define LPE_CONVERSION_TOLERANCE 0.01 // FIXME: find good solution for this.
The last parameter is a bool though. So?
Regards, Markus
-----Ursprüngliche Nachricht----- Von: Johan Engelen [mailto:jbc.engelen@...2592...] Gesendet: Sonntag, 23. März 2014 14:42 An: Markus Engel; 'Inkscape-Devel' Betreff: Re: AW: [Inkscape-devel] Possibly unitialized used of variable
On 23-3-2014 14:05, Markus Engel wrote:
Hi, neither gcc 4.8.1 nor clang 3.4 nor msvc 12 produce this warning, so I think this might be a false positive that has been fixed in newer compiler versions. I don't see how _b[1] could be not initialized...
Thanks for checking with newer compilers.
Here's the warning I currently like best: ../../trunk/src/gradient-drag.cpp:2390:69: warning: variable 'p' is uninitialized when used within its own initialization [-Wuninitialized] Geom::Point p = ls.pointAt(ls.nearestPoint(dragger->point + p));
My goodness, what a terrible bug. Fixed in rev. 13186.
Does everybody now see why warnings are important?! Yes newer compilers may throw more warnings, but they are *better* warnings and we *need* to error on them, *by default*.
Thanks, Johan