On 6/30/07, MenTaLguY <mental@...3...> wrote:
Most fonts have spaces in their names. That means that nearly all documents saved in 0.46 will be useless text-wise in <= 0.45.x. These are fonts that _worked just fine in 0.45_.
And they still work just fine _in 0.45_. The only problem is when you move documents from 0.46 to 0.45. And why would you do that? Just upgrade everyone to 0.46 when it's out.
Having considered this a bit, I think the best solution is to leave off the single quotes if:
- the family name has no leading or trailing whitespace
- the only whitespace chars in the font name are isolated ascii spaces
This is compatible with the CSS parsing rules, and it will allow most fonts that worked in 0.45 to continue working in a backwards-compatible way.
I have spent quite some effort on this fix, trying to find the approach which is valid and works with all the weird-named fonts that people attached to their bugreports. (I even had to fix a couple bugs in libcroco to make this work.) Perhaps my fix is not optimal. But please do not try to improve it unless you are willing to dig out all the now-closed bugreports and retest them again after your changes. I honestly don't think it's worth the effort if your only goal is compatibility with the deeply broken 0.45.