Hi Johan. I revert it.
About the last patch, my code is easy changeable by a ui toogle in each effect or in some of them. I also dislike the become complexity but think is need for correct work in the cases i tested.
Another approach could be a button in all/some LPE gui to apply the effect to the clip/mask. This remove the sweet live effect but simplify the code.
Whats your opinion?
Cheers, Jabier.
El vie, 27-06-2014 a las 00:36 +0200, Johan Engelen escribió:
On 26-6-2014 16:14, Jabiertxo Arraiza Cenoz wrote:
In last patch i upload a method to specify in the effect itself if is allowed to handle clips or mask.
I'm not sure, and think we should not add more hacks to this; I don't think it is good to add a flag for this to the LPE classes. For one thing, I think it is not a good idea to change behavior silently depending on what effect is applied. Perhaps a UI toggle is more suited here (say, a toggle in the Apply LPE chooser dialog).
Jabier, could you please for now remove the calls to sp_lpe_item_apply_to_mask and sp_lpe_item_apply_to_clippath, until we figure out a good solution? No need to remove the functions themselves (add a comment with a link to the bug report). I've reopened the bug report.
Thanks, regards, Johan