On 26/4/11 13:49, Krzysztof Kosiński wrote:
2011/4/26 Andrew <rugby471@...400...>:
So I have fixed all the bugs that have been found in the Gallery dialog, as well as adding in a Refresh button, as File Monitor that works on all platforms has not yet been found.
GFileMonitor (wrapped as Glib::FileMonitor in glibmm) does work on all platforms. If kernel-level monitoring support doesn't exist, it will periodically poll the file for changes.
Did you test it on all platforms Inkscape supports? As discussed on #inkscape (irc) with Andrew and commented in the merge proposal, using GFileMonitor added in r10101 of the branch [1] crashed Inkscape on OS X [2].
Note also that no builds have been done and tested on Windows so far (not with GFileMonitor nor the current solution using a Refresh button).
Sorry if this seems to overrate the importance of supporting other (commercial) platforms, but on irc I voted to implement a solution more likely to work in a cross-platform manner first (with a Refresh button), instead of an auto-refresh (directory monitoring) which crashes Inkscape on other platforms. 'Auto-Refresh' could be added anytime once the branch has been merged into trunk, but the basic features of the new Gallery dialog do not depend on it.
~suv
[1] http://bazaar.launchpad.net/~and471/inkscape/gallery/revision/10101 [2] backtrace: http://pastie.org/1819845