On Tue, 4 Jan 2005 13:26:56 -0800 (PST), Bryce Harrington <bryce@...260...> wrote:
Actually, it does use the 0.80 factor, but in its inverted fashion (1.25). However I chose to make px the primary unit so the conversion factors are expressed as functions of px's rather than pt's.
This sounds good. I just did mostly the same, now there's only one 0.8 defined in one place.
Actually what I need from SPUnit is this:
sp_pixels_from_units, sp_units_from_pixels
SP_PX_TO_METRIC_STRING (currently it's in SPMetrics, but this class is redundant, it should be merged with SPUnit)
functions to get ratios to and from px for all units (to replace the defines from unit-constants.h)
sp_get/set_value_in_pixels for an adjustment with a unit menu
If you provide this in your implementation of SPUnit, it will be almost a drop-in replacement. Just please don't touch any unit stuff outside of SPUnit and SPMetrics and SPUnitMenu, because there were tons of changes and fixes recently, throughout the codebase, caused by the removal of 0.8 and the change in base zoom. Please just provide the above API and it should be easy to merge.