Re: [Inkscape-devel] Weird bitfield declaration?

On 2013-10-15 22:48, Johan Engelen wrote:

Hi all, I just found this in sp-root.h:

class SPRoot : public SPGroup { ... bool viewBox_set : true;

I do not know what it means. Does it mean: bool viewBox_set : 1;

Sounds likely. It was just recently changed from an unsigned int to a bool (revision 12475.1.2), changing the 1 into true at the same time. Possibly the committer thought that it initialized the value. To be honest, the bitfield syntax in c++ is a little obscure, and I am wondering whether we actually /need/ a bitfield here. After all, how many sp-root's do we have lying around?

If so, let's change it to a more recognizable format?

Cheers, Johan