I committed your new save confirm dialog. Some comments:
See Bug #863856 for details about the save confirmation dialog. This is my attempt to make it 99% compliant to the HIG and I believe I succeeded. In fact, this might be the _first_ dialog ever to (almost) completely match the HIG suggestion. :) Considering the amount of work this required, I can also very well understand now, why this is the case...
It's good to be HIG compliant, but the new dialog is HUGE. Still, since it's not going to stay on screen all the time, I'm OK with that. Being wordy also won't hurt for novices.
Additionally, I commented out the non-standard dialog placing code (placing the dialog near the mouse pointer), as dialogs should really be placed by the window manager (at least that's what GNOME users will expect). I only commented the appropriate code out, so if you disagree about this, it would be easy to change again.
I still think popping a dialog at the mouse is better for usability, but again, this dialog is not so frequently needed so I think it's better to go the simple (and standards-compliant) route. Popping the fialog in the center of the document window seems to be conventional, so let it be that way.
There was also an issue when the user clicked "Save", but then canceled the dialog. This situation wasn't detected and so the document was closed, which is bad. To solve this, I made a few functions return a gboolean and this also solved a TODO item on the way. :)
Excellent, thanks!
Other stuff that might still be done:
- I noticed that overwriting of files wasn't handled at all, but
didn't want to get too much distracted...
It would be very nice if someone could finally take care of that. Recently Ted Gould introduced a module-based save system, and I saw some TODOs for this in his code, so you should perhaps discuss this with him first.
- Of course it would be very nice to show in the dialog, how much
time has passed since the document was last saved. This shouldn't be very complicated, but I didn't want to get too deep into the code (yet), because I'm very unexperienced. :)
Not sure about the time (although why not?), but one thing we absolutely need is an indication of whether the sodipodi:modified is on or not. On windows, it's conventional to add * to the filename in the title bar, don't know what HIG says about this.
I hope you take a look at the patch and tell me if I did anything wrong, because this is in fact the first patch I ever made.
Not that _I_ am a a very experienced programmer, but I did not see any problems with your patch. Everything seems neat.
Are you interested in doing more Inkscape work? If so we could give you developer access to the CVS.
_________________________________________________________________ Protect your PC - get McAfee.com VirusScan Online http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963