Am 05.03.2018 um 17:56 schrieb Eduard Braun:
Am 05.03.2018 um 13:31 schrieb Maren Hachmann:
I just added a picture, and a link to the release notes draft.
Great!
I noticed you removed the "codename" which I think we need for hiding pre-releases (or is there any other field to mark a release as pre-release which I overlooked?): https://gitlab.com/inkscape/inkscape-web/blob/master/releases/views.py#L150 (that is unless you specifically wanted to make the pre-release more visible)
However I'm not sure it works as I think it should as https://inkscape.org/en/release/ still points to the pre-release (which I assume it should not?). Maybe a caching issue?
- I tested after I changed it, and it didn't show up as primary download for me (but it did change, so I assumed it had worked). I found that duplicated name ugly...
According to the source code, what makes a pre-release a pre-release is not the 'pre' in its name, but that its parent (the release, in this case 0.92.3) does not have a date set, or the date is set after the pre-release's date.
(https://gitlab.com/inkscape/inkscape-web/blob/master/releases/models.py#L132)
So the code name doesn't make a difference, we should be able to safely remove it again. May I try?
Maren
As Inkscape does not use codenames for releases, maybe we can drop the codename field altogether?
Regards, Eduard