On 2013-06-06 02:14 +0100, Jon Cruz wrote:
On Jun 5, 2013, at 11:36 AM, ~suv wrote:
On 2013-06-05 11:39 +0100, LucaDC wrote:
I can't compile r12347 under Windows XP: glibmm/threads.h: No such file or directory Luca
Reproduced with trunk builds of r12347 on Mac OS X 10.5.8 with older versions of glib, glibmm and gtkmm (X11 as well as Quartz backend):
I should have a configure.ac fix for that shortly.
1) Revision 12353 fails to compile with older (2.28.x) and newest (2.36.x) glib/glibmm versions (different errors):
On legacy Mac OS X 10.5.8 system with - glib 2.28.8, glibmm 2.28.2, gtkmm 2.24.2:
CXX ui/dialog/filedialog.o In file included from ui/dialog/filedialog.cpp:19: ui/dialog/filedialogimpl-gtkmm.h:24:28: error: glibmm/threads.h: No such file or directory CXX ui/dialog/filedialogimpl-gtkmm.o In file included from ui/dialog/filedialogimpl-gtkmm.cpp:24: ui/dialog/filedialogimpl-gtkmm.h:24:28: error: glibmm/threads.h: No such file or directory make[3]: *** [ui/dialog/filedialog.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: *** [ui/dialog/filedialogimpl-gtkmm.o] Error 1 make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2
AFAICT the build failure here is due to a typo in the earlier revision (in 'src/ui/dialog/filedialogimpl-gtkmm.h' the include line had been added twice in r12347, but in r12353 only one of them is put inside the #if … #endif condition)
On up-todate OS X 10.7.5 with - glib 2.36.2, glibmm 2.36.2, gtkmm 2.24.3 (patched via MacPorts):
CXX ege-adjustment-action.o In file included from /Volumes/magenta/mp-trunk/quartz/include/glibmm-2.4/glibmm.h:89, from /Volumes/magenta/mp-trunk/quartz/include/gtkmm-2.4/gtkmm/stockid.h:26, from /Volumes/magenta/mp-trunk/quartz/include/gtkmm-2.4/gtkmm/iconset.h:35, from /Volumes/magenta/mp-trunk/quartz/include/gtkmm-2.4/gtkmm/style.h:46, from /Volumes/magenta/mp-trunk/quartz/include/gtkmm-2.4/gtkmm/rc.h:31, from /Volumes/magenta/mp-trunk/quartz/include/gtkmm-2.4/gtkmm/widget.h:48, from ../../src/widgets/icon.h:21, from ../../src/ege-adjustment-action.cpp:45: /Volumes/magenta/mp-trunk/quartz/include/glibmm-2.4/glibmm/threads.h:203: error: field ‘gobject_’ has incomplete type /Volumes/magenta/mp-trunk/quartz/include/glibmm-2.4/glibmm/threads.h: In member function ‘GThread* Glib::Threads::Thread::gobj()’: /Volumes/magenta/mp-trunk/quartz/include/glibmm-2.4/glibmm/threads.h:199: error: ‘gobject_’ was not declared in this scope /Volumes/magenta/mp-trunk/quartz/include/glibmm-2.4/glibmm/threads.h: In member function ‘const GThread* Glib::Threads::Thread::gobj() const’: /Volumes/magenta/mp-trunk/quartz/include/glibmm-2.4/glibmm/threads.h:200: error: ‘gobject_’ was not declared in this scope make[3]: *** [ege-adjustment-action.o] Error 1 make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2
OTOH the build of r12353 succeeds on OS X 10.7.5 with these versions: - glib 2.32.4, glibmm 2.32.1, gtk+/x11 2.24.13, gtkmm 2.24.2 - glib 2.34.3, glibmm 2.34.1, gtk+/quartz 2.24.17, gtkmm 2.24.2
2) Doesn't the new check introduced in revision 12353 [1] duplicate one already introduced in r12337 [2] for the same purpose?
3) AFAICT the latest changes in r12353 do not address includes in files compiled for optional features i.e. if ImageMagick, libcdr and libvisio are detected by configure - see also comment #10 in bug #1179338.
[1] http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12353#configure.ac [2] http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12337#configure.ac