On 2013-09-19 04:09 +0200, Krzysztof Kosiński wrote:
There are basically two issues which stand out:
- Inconsistent whitespace
- Use of explicit this-> instead of marking member variables with a
leading underscore.
However, I think these two stylistic problems can be fixed later and it's better to commit now than to wait and let this important work get out of sync with trunk.
I committed the merge as revision 12532.
After the merge in r12532 'File > Document Properties > Grids' no longer display the settings for defined grids (works with r12531, fails with r12532).
Steps to reproduce: 1) launch Inkscape (default prefs, default new doc) 2) toggle on grid (menu 'View > Grid') to create a default grid 3) open 'File > Document Properties > Grids' to edit the settings
Expected result: The settings for the new grid are accessible on the 'Grids' page
Actual result: The 'Defined grids' section is empty.
Warning on the console: ** (inkscape-12532:13355): WARNING **: TypeNotRegistered exception: inkscape:grid
(tested and confirmed on Ubuntu 12.10 and OS X 10.7.5)