On Tue, Feb 26, 2008 at 10:51:48AM -0800, Bryce Harrington wrote:
Bryce,
I was trying to review bitmap effects and found two where translation is not used properly.
This could potentially benefit more then just those two effects and would also allow for the combox box items in the idx files to be translatable.
If it fixes a detectable bug in the UI, and requires no string changes, it would definitely be a candidate for inclusion. However, if it turns out that further work is needed to get things hooked up properly, it would be best to leave for 0.46.1 or 0.47.
I found the culprit and created a patch (attached). I hesitated for a moment as to where to fix the problem, since there are two ways of doing it (in paramenum.cpp and in the extensions files). Since I don't know the reasons behind the particular line in the former I fixed the latter. Should help.
PS. I have a feeling more could be fixed as it seems translations are ignored in some other places for internal (cpp) extensions, but I can see into that as a next step.
Regards, -- Marcin Floryan http://marcin.floryan.pl/ [GPG Key ID: 0D5581C5]