On Thu, 2013-09-12 at 18:28 +0200, Krzysztof Kosiński wrote:
This subset is not tiny by any reasonable standard.
Teeny-tiny wibbly-wobbly subset. ;-)
BUT thanks to your fantastic code (with a few tweaks), even thus subset is doomed to have their files work properly in Inkscape.
The only regression from that to this is that it now fails to open files with both system entities and ns record entity replacement. replacing system with spaces allowed libxml2 to parse the entity as if it were a literal. But I'm not touching that regex, it's perfect enough for me.
Compiled, tested with files, if there's no other problems. I'll merge it and get this bug wrapped up.
Note: this new replacement code is ONLY run when the first open fails with a specific kind of problem seen in adobe files. Other files with entities will continue to not be replaced until libxml2 is fixed properly, but at least those files will still open.
Martin,