On 2010-11-07 23:34, Krzysztof KosiĆski wrote:
Please tell me how do you feel about removing the following code:
- dom/
- pedro/
- jabber_whiteboard/
- Scripts dialog
- Java binding stuff
- one of the Find dialogs
- native Windows file dialogs
As you may have noticed the last item on the list is subject of the debate, as for the rest: be my guest! Any dead or nearly dead code we remove will generally lead to a lighter, more stable and more maintainable Inkscape! I'd also love to eliminate one of pixblock-transform and nr-compose-transform, but perhaps some of the GSoC Cairoification work has taken care of this already.
Rationale:
- dom/ and Java binding are obsolete, the DBus binding should be used
instead. For high performance applications there could be a binary plugin API, but I'd prefer to do that once the internal APIs are sane (right now they are far from it).
Does the DBus binding work on Windows btw? If so, is there somewhere where I can read up on how to use it?
- pedro/ and jabber_whiteboard/ contain Inkboard stuff which doesn't work.
- The purpose of the script dialog evades me. To what extent does the
scripting capability work?
- There are two Find dialogs, one of them is disabled with a notice in
the code encouraging to test it. This should be finally resolved.
- Native file dialogs are a maintainability nightmare and aren't that
much better than GTK dialogs; they are the reason I went for the "embed / link" popup hack for images instead of putting the checkbox in the import dialog.
I seem to remember that I also didn't like the GTK dialog much, but if you'd like to argue that Inkscape is not the proper place to fix it then I'd tend to agree. So personally I wouldn't be against removing the native dialog code from Inkscape. If we don't like it, lets try to fix it in GTK, and not make our code more complicated. (If you'd like to be on the safe side, make the native dialog optional for now, with a hidden switch or even a compile time option, if that's easy to do, then we can have some transition time.)