I still haven't gotten unit tests building locally, but gitlab builds them just fine.

Looking forward to discussing the PR if anybody is interested.

-- Early

On Thu, Oct 15, 2020 at 11:22 AM Early Ehlinger <earlye@gmail.com> wrote:
Hello Inkscape Devs,

I've put together this pull request: https://gitlab.com/inkscape/inkscape/-/merge_requests/2405

I've run into a bit of a snag on the unit test front because make check doesn't show as a valid target, even though I've run download-gtest.sh and re-run cmake.

cmake complains that:

-- Could NOT find GTest (missing: GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY)
CMake Warning at CMakeLists.txt:187 (message):
  No gtest found! Disabling testing...

I'm going to keep hacking at this, but would love any advice and/or to discuss the PR in the meantime.
--
Early Ehlinger


--
Early Ehlinger