On 4/6/10 21:56, Tavmjong Bah wrote:
Just checked in support for the baseline-shift attribute. The attribute is now fully supported except for a GUI. The Text toolbar now has two buttons to set/unset superscripts and subscripts. These combine a baseline shift with a font-size change. There are two new strings to translate in the tooltips for the buttons. I still need to add proper icons for the buttons. Also, there is one bug where the baseline-shift is reset if one adds a character to the <tspan> containing a subscript or superscript (it doesn't reset if it the baseline-shift is defined a different way.
Using the new features sub/superscript adds 'baseline-shift:super' or 'baseline-shift:sub' (the last one used?) to the style of the desktop group in the preferences file. This causes the console to be flooded with warnings when using 0.47 with the same preferences file as the current devel build:
WARNING **: Unimplemented style property SP_PROP_BASELINE_SHIFT: value: super
or
WARNING **: Unimplemented style property SP_PROP_BASELINE_SHIFT: value: sub
Why is 'baseline-shift' part of the desktop style? It seems unlikely to me that new (or default) text should use a sub or super baseline-shift as default (but I don't know about the inner workings of the preferences system and what role <group id="desktop" style="..."> really has).
Possibly related to the preferences bug [1] (missing default styles for most shape tools after resetting the preferences)? See comment #4 by JazzyNico: «It seems that the line-height, letter-spacing and word-spacing attributes are incorrectly stored in the preferences desktop group. It leads to a loss of swatch styles for the shape tools.»
~suv