On 2014-02-11 12:49 +0100, Tavmjong Bah wrote:
On Tue, 2014-02-11 at 03:02 +0100, su_v wrote:
On 2014-02-06 15:44 +0100, Tavmjong Bah wrote:
While mucking about the code I noticed that the same basic code to handle viewBox and preserveAspectRatio appeared in multiple files (8 times?) having originally been pasted directly or copied with some changes. Overtime the code was tweaked here and there.
I have created a new base class to handle viewBox and preserveAspectRatio and modified sp-root, sp-symbol, sp-image, sp-pattern, and marker to use the new class, resulting in a reduction of over 400 lines of code (yeah!). In the process, I've fixed a number of issues with using percentage based x, y, width, and height values.
Please let me know if you find any problems.
Changes of r13002 affecting other parts of Inkscape:
- Bug #1278645 “image handling in sp-image corrupts EMF/WMF output” https://bugs.launchpad.net/inkscape/+bug/1278645
I've set 'preserveAspectRatio' to 'none' in importing an image, r13020.
If compatibility with old Inkscape files is important, we could set 'preserveAspectRatio' to 'none' on opening a file (if it is not already set). This would break non-Inkscape generated files.
Does the EMF/WMF bug still exist after r13020?
Yes, bug #1278645 still exists.
Another recent report seems to be triggered by the changes in r13002 and is not fixed with the latest changes either:
- Bug #1278571 “Inkscape crashes on bitmap update (rev >= 13002)” https://bugs.launchpad.net/inkscape/+bug/1278571