On 6/14/07, bulia byak <buliabyak@...400...> wrote:
On 6/10/07, Bill Baxter <wbaxter@...400...> wrote:
https://sourceforge.net/tracker/?func=detail&atid=604308&aid=1734633&group_id=93438
>
> Comments / suggestions appreciated.

I tried the patch and the code seems to work fine. However I'm not
sure about the UI. Right now it just adds another checkbox so the
Windows tab in prefs has two checkboxes side by side: "Save window
geometry with documents" and "Remember window geometry". This is very
confusing, and the fact that they are both checkboxes means that there
are 4 different possible settings, each one potentially with its own
quirks and, in any case, each one requiring its own documentation. So
what I propose instead is using two radio buttons:

- Save and restore window geometry for each document
- Remember and use last window's geometry

I don't think anyone will want to use a combination of these options -
it's usually one way or the other.

What do you think?

Well I could imagine someone wanting to use both (the behavior I implemented uses document-stored positions if available and falls back to prefs otherwise -- if both options are checked).
But I think it's fringe enough and difficult enough to explain the connection between those two that the radio is better.

I think the tool-tip helps should say something like:

   "Save and restore window geometry for each document (saves geometry in the document)"
   "Remember and use the last window's geometry (saves geometry to user preferences)"

Otherwise it's not at all obvious that setting 1 will make changes to documents that are visible to other users.

Shall I implement the change or can you do it?

--bb