On Mar 4, 2010, at 6:35 AM, Krzysztof Kosiński wrote:
Jon, you "fixed" the problem by adding a lot of ugly defines... I *really* wanted to avoid this. You should have just reverted my commit. http://doc.bazaar.canonical.com/current/en/user-guide/adv_merging.html#rever...
Well... yes a revert would have possibly unblocked the immediate build issues...
... but in the long run it is far better to fix the source to work on all platforms rather than fix the platforms to work with the source.
The only real ugly defines in play are those where the custom hash functions are implemented. We probably should revisit those at some point anyway since I'm *extremely* interested in the hash balancing and performance of using pointers as hash values.
*Please* keep in mind that Inkscape uses autotools for a reason. Take a look at the existing configure.ac and some of the checks that it runs. Also check the output and logs. Keeping things easier to build for new users is a *KEY* tenant of the project. We need to keep that low barrier to entry.
Oh, and to illustrate, I *did* try to update my OS X build environment to newer components, but that failed and left me with a broken toolchain (via macports). That's one of the things about the mac platform. Each and every user has a good toolchain included with the OS when they get it, but trying to move to anything beyond the stock does get a bit risky.