W dniu 25 stycznia 2010 06:28 użytkownik ~suv <suv-sf@...58...> napisał:
Can I ask you two more general questions related to changes from your node-tool merge? (I'm just curious and trying to better understand):
a) date removed from about-dialog I reverted this change locally because when testing different builds e.g. with different patch versions from the bug tracker that don't change the revision number - or re-building after external changes - I thought the build date at least as useful as the revision number (during development phases I wouldn't mind including the build time as well). I'd like to understand the reason to reduce the 'About' info to the revision number only, while trunk is still open for so many changes?
The problem was that the date displayed in the dialog was not the actual date of the build, but the date of building the aboutbox.cpp file. Since that file doesn't change too often, it would not be accurate. I changed it so that the date was included in the version string that gets written to inkscape-version.cpp, but probably it got lost during the Bazaar transition.
b) src/ui/icon-names.h When comparing available lists of icon names (wiki, src) I noticed that your new 'node-transform' icon has no entry in the macro list for icon names. Will the list in 'src/ui/icon-names.h' no longer be the most up-to-date list of named Inkscape icons?
I think that file wasn't a very good idea to begin with - changing the names will cause the define names to be out of sync with actual names, which is confusing, and changing any icon name or adding one will cause extensive rebuilds, because icon-names.h is included in many files. I have a different solution to the "list of all icons" problem that I'll share later.
p.s. btw - I am *very* pleased with the new transformation handles for selected nodes: it is the first time ever I can savor the ability to rotate nodes! Previously this action was accessible only by keyboard shortcuts which completely fail with many localized keyboard layouts ([,]) *and* - iiuc - bypass verbs and thus any custom keyboard shortcut mapping ;(
I'll consider adding a verb or GtkAction for each keyboard action in the node tool. This problem of non-configurable keybindings is not limited to the node tool, by the way, though probably it's the most noticeable in the node tool due to the large number of shortcuts it has.
Regards, Krzysztof