On 31-8-2013 17:11, Martin Owens wrote:
On Sat, 2013-08-31 at 16:18 +0200, Johan Engelen wrote:
there is no need for merge reviews anymore.
I feared that's what you meant. For medium-large code though, it's always helpful to have a review from fellow coders. None of us are perfect and lots of us know C++ like some foreign land.
Encouraging more with commit access to do review isn't such a bad idea.
Reviewing code is not related to the use of branches or not.
I follow trunk changes [1] very closely and I'm not the only one. Merge requests are much less noticeable. Also, testing a branch for functionality is more effort than simply running trunk and see. For this particular example of the pdf+tex output change, I would have much preferred a commit to trunk, then a mail to the devlist asking for a quick check, etc.
Cheers, Johan
(I see the value of branches, but in a human-resources-starving project like ours, I feel that branches carry a lot of weight and have large disadvantages. Being with the project for so long makes me quite conservative I guess, but I think we've done very well without branches and other fanciness. ;)
[1] http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/changes