On 1/16/13 8:56 AM, ~suv wrote:
- No keyboard shortcuts for menu items - No hints for menu items in
the status bar - ... (see my earlier replies for related bug report numbers) Are these indeed issues which need to be fixed in platform-/distro-/desktop- and/or backend-specific patches, or is it reasonable to assume that they are rooted in the same structure of Inkscape's current code base, and might have a better chance to get addressed in a joint effort if not being tagged with 'osx only'?
This is due to the fact that Inkscpae does not use GtkAccel in menuitems' GtkLabels. Without adding that logic, it won;t happen. Are menu accelerators symbols a show stopper for an OSX 0.48.4?
- Quit, About and Preferences menu items moved under the app menu.
For the preferences dialog in the application menu, users are likely to expect the typically used shortcut 'Cmd+,' to also work with "native" Inkscape. AFAIU this would need special attention similar to the conflict with the quickzoom feature for 'Cmd+Q' - ',' is hardcoded in the select context to scale the current selection and seems to ignore whether 'Meta' is pressed or not.
Same as before GtkAccel has to be implemented.
Works for all but CorelDraw files (e.g. CDR) - even very simple CDR files I had available for testing (no text, no embedded data or images, only paths/curves) failed to open with the UniConvertor module as currently included in the app bundle:
UniConvertor failed:
Traceback (most recent call last): File "/Users/su_v/Applications/TST/Inkscape-0.48.4-RC1.app/Contents/Resources/python/site-packages/sk1libs/filters/import/cdrloader.py", line 837, in Load self.import_curves() File "/Users/su_v/Applications/TST/Inkscape-0.48.4-RC1.app/Contents/Resources/python/site-packages/sk1libs/filters/import/cdrloader.py", line 880, in import_curves self.begin_page("",layout) AttributeError: CDRLoader instance has no attribute 'begin_page' Traceback (most recent call last): File "<string>", line 1, in <module> File "/Users/su_v/Applications/TST/Inkscape-0.48.4-RC1.app/Contents/Resources/python/site-packages/uniconvertor/__init__.py", line 95, in uniconv_run doc = load.load_drawing(input_file) File "/Users/su_v/Applications/TST/Inkscape-0.48.4-RC1.app/Contents/Resources/python/site-packages/uniconvertor/app/io/load.py", line 377, in load_drawing return load_drawing_from_file(file, filename) File "/Users/su_v/Applications/TST/Inkscape-0.48.4-RC1.app/Contents/Resources/python/site-packages/uniconvertor/app/io/load.py", line 354, in load_drawing_from_file raise SketchLoadError(_("Parsing error: ")+ str(value)) app.events.skexceptions.SketchLoadError: Parsing error: Parsing error: CDRLoader instance has no attribute 'begin_page'
The same CDR file(s) open ok with Inkscape & UniConvertor 1.1.4 on Ubuntu 12.10 (64bit, VM, Python 2.7), and with Inkscape & a rather dated tweaked installation of UniConvertor 1.1.5 for Python 2.6 on my older laptop with Mac OS X 10.5.8 (i386): Sample file from the bug tracker: https://bugs.launchpad.net/inkscape/+bug/442010/+attachment/771958/+files/Frenchcurve.cdr
I had no test files at hand for the other CorelDraw input file formats (CCX, CDT, CGM, CMX).
The remaining input formats based on UniConvertor (AI 8.0 and older, PLT, SK1, WMF) seem to work, as do the output formats (PLT, SK1, WMF) - tested and confirmed by round-trip editing a minimal Inkscape document with Inkscape.app (SVG -> PLT|SK1|WMF -> SVG).
Uniconvertor is not an easy package to fix. I'm going to look into it as time permits.
- WRT Crash on exit, or random dialogs from output extensions:
Bug #1046068 is not fixed by including a (semi- or fully-functional) UniConvertor 1.1.5 module in the app bundle, and while with the latest RC1 package Inkscape 0.48.4 doesn't prompt with annoying error dialogs from UniConvertor-based output extensions anymore, it leaves a file with a copy of the clipboard content in $TMPDIR, each time the app is exited with a non-empty clipboard, and has a noticeable delay on exit if the clipboard was not empty (since apparently the clipboard content is attempted to be exported to all supported clipboard targets based on the internal list of output extensions).
The "shortest path to annoyance removal" postpones a fix, and Inkscape is likely to face the same issue again in a few weeks or months, as soon as there are beta releases or release candidates of 0.49 available (trunk currently crashes right after creating a zero-size temp file in $TMPDIR if there is a at least one script-based output extension loaded either from the shared extensions directory or from the user Inkscape profile directory "$XDG_CONFIG_HOME/inkscape/extensions")
The annoyance was to me. If you want to see it revert this line
return ['/System/Library/Fonts', '/Library/Fonts', os.path.expanduser("~/Library/Fonts")]
back to
return ['/',]
When exiting with something in the clipboard, Inkscape will invoke a lower uniconvertor process that will scan all of the main disk. The python process will eat up all your memory, the all of your swap till it will freeze the Mac. I call that a major annoyance. The problem is why does Inkscape invoke that process when items are on the clip. I suspect is trying to leave something on the system clipboard in a particular format. That's where the fix should be
a) Assume a user somehow has managed to install 'gimp' (or a wrapper script to GIMP.app) into one of the paths in the app bundle's $PATH variable (add a fake 'gimp' shell script into 'Contents/Resources/bin' to test it): there's yet another dialog now appearing on quit from the GIMP XCF output file type (one or more layers are required, the clipboard content however is saved without layer information). Or the user has some additional extensions installed in '~/.config/inkscape/extensions' - those may also trigger the same issue (depending on the custom output extension).
b) Upstream bugs: including the UniConvertor module doesn't prevent related crashes which may get triggered with Inkscape 0.48.4 on exit, too, after having used the system clipboard to copy and paste e.g. text in Inkscape.app (e.g from GUI widgets containing text or digits) to native osx apps:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 ??? 000000000000000000 0 + 0 1 libgtk-quartz-2.0.0.dylib 0x000000010b2642ac gtk_clipboard_store + 268 2 libgtk-quartz-2.0.0.dylib 0x000000010b26432f _gtk_clipboard_store_all + 63 3 libgtk-quartz-2.0.0.dylib 0x000000010b135bc9 gtk_main + 537 4 Inkscape 0x00000001099aac24 sp_main_gui(int, char const**) + 1812 5 Inkscape 0x00000001099aafe1 main + 337 6 Inkscape 0x00000001099a8184 start + 52
(above crash occurred on exit with the RC1 package after copy&pasting the error messages from failed CDR import attempts into native OS X application (MacVim, Thunderbird), working in those other applications for a while before returning to Inkscape and closing it. Similar steps to reproduce the crash in GTK+/Quartz 2.24 are described e.g. in https://bugzilla.gnome.org/show_bug.cgi?id=626499#c18)
therw is a problem with the clipboard that needs to be analyzed.
V.