31 Jul
2013
31 Jul
'13
7 p.m.
2013/7/31 Markus Engel <p637777@...1081...>:
- singleton.h should be merged into sp-factory.h. Singletons should be avoided where possible, so a separate singleton header is not a good idea. Boost doesn't have a singleton header for the same reason.
I just did that as I noticed there are some other classes that use a singleton pattern as well, e. g. DocumentMetadata.
Using a singleton is OK in the case of SPFactory, since I don't think there is any use in defining some other set of SPObject-constructing functions. The only issue I have here is that the content of singleton.h should be in sp-factory.h.
Regards, Krzysztof