For an LPE doEffect method, it is always safe to return the input path ("pwd2_in") in case of error or undefined behavior.
In this case, the method only reaches its end when both xx and yy are false, which means all bend paths are disabled: return input path.
Fixed in svn, thanks for mentioning the issue.
Johan
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of Jon A. Cruz Sent: donderdag 12 juni 2008 4:30 To: Inkscape Devel List Subject: [Inkscape-devel] warning in LPE
Does anyone have insight on this:
live_effects/lpe-envelope.cpp: In member function'virtual Geom::Piecewise<Geom::D2Geom::SBasis > Inkscape::LivePathEffect::LPEEnvelope::doEffect_pwd2(const Geom::Piecewise<Geom::D2Geom::SBasis >&)':
live_effects/lpe-envelope.cpp:218: warning: controlreaches end of non-void function
I've been thinking I can address the structural and return issues, but I'd need to know what *should* be returned in the fallback case. Any ideas?
Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel