What direction is inkscape taking, expand use of icon.c generic subroutines, or use direct gtk calls?
ie, do we expand use of: img = sp_icon_new(...) gtk_widget_show(img) or use img = gtk_image_new_from_file(...) gtk_widget_show(img)
I'm looking into the bug where if you open the transformations dialog twice, inkscape will crash. The bug lies in the use of the icon.c routines. The transformations dialog is the only dialog to use the icon routines. I think we can quickly get rid of the crash by not using sp_icon_new. Otherwise I need to hunt more in the icon routines and see why the sp_icon_destroy is segfaulting.
Cheers, Rob. http://members.rogers.com/rcrosbie
_________________________________________________________________ Add photos to your e-mail with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/photos&pgmarket=en-ca&RU=http%3a%...
On Sat, 2003-11-08 at 23:14, Robert Crosbie wrote:
What direction is inkscape taking, expand use of icon.c generic subroutines, or use direct gtk calls?
Well, in my opinion we should do neither of the two below, actually. Specifically, we should be using the GtkStock system rather than explicitly loading images from files or doing the sp_icon_(...) stuff ourselves.
ie, do we expand use of: img = sp_icon_new(...) gtk_widget_show(img) or use img = gtk_image_new_from_file(...) gtk_widget_show(img)
I think short-term we should get rid of sp_icon_*, as it represents a dead end, development-wise.
I'd file a bug to track this, but Sourceforge seems to be down at the moment...
-mental
On Sun, 9 Nov 2003, MenTaLguY wrote:
On Sat, 2003-11-08 at 23:14, Robert Crosbie wrote:
What direction is inkscape taking, expand use of icon.c generic subroutines, or use direct gtk calls?
Well, in my opinion we should do neither of the two below, actually. Specifically, we should be using the GtkStock system rather than explicitly loading images from files or doing the sp_icon_(...) stuff ourselves.
ie, do we expand use of: img = sp_icon_new(...) gtk_widget_show(img) or use img = gtk_image_new_from_file(...) gtk_widget_show(img)
I think short-term we should get rid of sp_icon_*, as it represents a dead end, development-wise.
I'd file a bug to track this, but Sourceforge seems to be down at the moment...
Wiki seems to be relatively reliable; maybe add it to the roadmap?
Bryce
participants (3)
-
Bryce Harrington -
MenTaLguY -
Robert Crosbie