Patch review needed for bug #1127103 (Colour change on blurred elements with a transform) (blocker)
It would be great if someone familiar with the rendering of SVG filter effects and colorspaces for SVG filters could review the latest patch in
- Bug #1127103 “Colour change on blurred elements with a transform” https://bugs.launchpad.net/inkscape/+bug/1127103
Summary: Blurred objects which have a 'matrix()' transformation, or are inside a container with such a 'matrix()' transformation, may render with a different (darker) shade of the original color, depending on whether or not the filter definition of the blur has the style property 'color-interpolation-filters:sRGB' added:
- with 'color-interpolation-filters:sRGB': original color - without 'color-interpolation-filters:sRGB': darker shade of color
Affects: - transformed blurred objects in documents created with stable versions - transformed objects blurred via 'Fill & Stroke' with current trunk
Does not affect: - transformed objects blurred via Filter Editor with current trunk
Proposed patch:
Comments by patch author: "I think the best thing we can do is set a defautl render colorspace. (…) i made the change for use sRGB instead linearRGB by default. Now the file opens OK but im not sure about others problems. Tav has some post about linearRGB in filters..."
Direct link to proposed diff: https://bugs.launchpad.net/inkscape/+bug/1127103/+attachment/3813130/+files/bug1127103-3.patch
I can have a look but not till the end of next week.
Tav
----- Original Message ----- | From: "su_v" <suv-sf@...58...> | To: "Inkscape Devel List" inkscape-devel@lists.sourceforge.net | Sent: Saturday, September 14, 2013 8:04:52 AM | Subject: [Inkscape-devel] Patch review needed for bug #1127103 (Colour change on blurred elements with a transform) | (blocker) | | It would be great if someone familiar with the rendering of SVG | filter | effects and colorspaces for SVG filters could review the latest patch | in | | - Bug #1127103 “Colour change on blurred elements with a transform” | https://bugs.launchpad.net/inkscape/+bug/1127103 | | | Summary: | Blurred objects which have a 'matrix()' transformation, or are inside | a | container with such a 'matrix()' transformation, may render with a | different (darker) shade of the original color, depending on whether | or | not the filter definition of the blur has the style property | 'color-interpolation-filters:sRGB' added: | | - with 'color-interpolation-filters:sRGB': original color | - without 'color-interpolation-filters:sRGB': darker shade of color | | | Affects: | - transformed blurred objects in documents created with stable | versions | - transformed objects blurred via 'Fill & Stroke' with current trunk | | Does not affect: | - transformed objects blurred via Filter Editor with current trunk | | | Proposed patch: | | Comments by patch author: | "I think the best thing we can do is set a defautl render colorspace. | (…) | i made the change for use sRGB instead linearRGB by default. Now | the file opens OK but im not sure about others problems. Tav has some | post about linearRGB in filters..." | | Direct link to proposed diff: | https://bugs.launchpad.net/inkscape/+bug/1127103/+attachment/3813130/+files/bug1127103-3.patch | | ------------------------------------------------------------------------------ | LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! | 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, | SharePoint | 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack | includes | Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13. | http://pubads.g.doubleclick.net/gampad/clk?id=64545871&iu=/4140/ostg.clk... | _______________________________________________ | Inkscape-devel mailing list | Inkscape-devel@lists.sourceforge.net | https://lists.sourceforge.net/lists/listinfo/inkscape-devel |
participants (2)
-
unknown＠example.com -
su_v