Fwd: [Branch ~inkscape.dev/inkscape/trunk] Rev 13946: Isolate components of libgc
On Wed, Feb 25, 2015 at 6:46 PM, Krzysztof Kosiński <tweenk.pl@...972.....> wrote:
Just a few notes:
- This change is asking for trouble. "gc" is already used as the
library name of Boehm GC, which we are linking to, so these internal GC components should be called "libinkgc" instead to avoid possible naming conflicts. 2. The convention so far was that "lib*" directories in the source tree are for in-tree forks/copies of third party libraries (except "libnrtype").
Fixed in r13950. I'll try to stick to convention in the future regarding this area.
Seems there's a linker problem:
Make error line 448: LINK problem: build\obj\inkgc\gc.o:gc.cpp:(.text+0x424): multiple definition of `Inkscape::GC::request_early_collection()' build\obj\gc.o:gc.cpp:(.text+0x424): first defined here build\obj\inkgc\gc.o:gc.cpp:(.text+0x5a0): multiple definition of `Inkscape::GC::Core::init()' build\obj\gc.o:gc.cpp:(.text+0x5a0): first defined here build\obj\inkgc\gc.o:gc.cpp:(.data+0x0): multiple definition of `Inkscape::GC::Core::_ops' build\obj\gc.o:gc.cpp:(.data+0x0): first defined here collect2: ld returned 1 exit status
Compiling r13950 under Windows XP SP3.
-- View this message in context: http://inkscape.13.x6.nabble.com/Re-Branch-inkscape-dev-inkscape-trunk-Rev-1... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
Oops, sorry: written too fast without first checking; I thought I'd triggered a clean build but it wasn't so. Now doing a true clean build that will take a while...
-- View this message in context: http://inkscape.13.x6.nabble.com/Re-Branch-inkscape-dev-inkscape-trunk-Rev-1... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
Just to confirm my mistake: clean build successfully completed. Sorry for the noise.
-- View this message in context: http://inkscape.13.x6.nabble.com/Re-Branch-inkscape-dev-inkscape-trunk-Rev-1... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
participants (2)
-
Liam White -
LucaDC