Re: [Inkscape-cvs] SF.net SVN Commit: inkscape: [10901] replaced connectors in connector layout icon with ordinary line to fix weird bug that
Log Message:
replaced connectors in connector layout icon with ordinary line to fix weird bug that needs a better solution! basically, connectors in the icon were being confused with connectors in the main document and ids were overlapping and causing problems when trying to extract the connector graph
If the connector code confuses conflates elements with the same ID in different documents, that's a VERY, *VERY* serious issue.
I sincerely hope this isn't a result of inappropriate use of global variables...
-mental
On Tue, 14 Feb 2006 mental@...3... wrote:
Log Message:
replaced connectors in connector layout icon with ordinary line to fix weird bug that needs a better solution! basically, connectors in the icon were being confused with connectors in the main document and ids were overlapping and causing problems when trying to extract the connector graph
If the connector code confuses conflates elements with the same ID in different documents, that's a VERY, *VERY* serious issue.
I sincerely hope this isn't a result of inappropriate use of global variables...
Yes, I discovered the problem with icons and multiple documents yesterday afternoon as a result of troubleshooting a bug Tim was seeing, and then chating to JonCruz on jabber. The connector code does confuse IDs currently. And I agree completely with how serious a problem that is.
This comes out of having a single instance of libavoid, rather than one per document. This was really just due to the false assumption on my part doing the Summer of Code work, in not really understanding the ideas of separate documents properly and how that works within Inkscape.
I've been working on the fix this morning, so it will be in the codebase shortly. Tim just commited that change to the icons file to allow him to keep working on his graph layout code without seeing the problem.
Cheers, Michael
On Wed, 15 Feb 2006, Michael Wybrow wrote:
On Tue, 14 Feb 2006 mental@...3... wrote:
If the connector code confuses conflates elements with the same ID in different documents, that's a VERY, *VERY* serious issue.
I've been working on the fix this morning, so it will be in the codebase shortly. Tim just committed that change to the icons file to allow him to keep working on his graph layout code without seeing the problem.
I have tested and committed the fix for this problem. There is now a separate instance of the connector routing code for each document.
Cheers, Michael
Michael Wybrow wrote:
On Wed, 15 Feb 2006, Michael Wybrow wrote:
On Tue, 14 Feb 2006 mental@...3... wrote:
If the connector code confuses conflates elements with the same ID in different documents, that's a VERY, *VERY* serious issue.
I've been working on the fix this morning, so it will be in the codebase shortly. Tim just committed that change to the icons file to allow him to keep working on his graph layout code without seeing the problem.
I have tested and committed the fix for this problem. There is now a separate instance of the connector routing code for each document.
Unfortunately it's not compiling on win32 now (compiled fine on my Linux box though)... http://pastebin.com/556104
-Josh
On Wed, 15 Feb 2006, Joshua A. Andler wrote:
Unfortunately it's not compiling on win32 now (compiled fine on my Linux box though)... http://pastebin.com/556104
Seems Bob fixed this while I was sleeping. Thanks!
Michael
participants (3)
-
unknown＠example.com -
Joshua A. Andler -
Michael Wybrow