On Sun, Jul 11, 2004 at 03:34:39PM -0700, Mike Hearn wrote:

On Sun, 2004-07-11 at 14:04 -0700, Kees Cook wrote:

...

We've disabled binreloc by default so that some of the other developers aren't disturbed by it. In the meantime, if your nightly builds can be changed to add "--enable-binreloc" to the "configure" run, Inkscape will correctly compile binreloc.

Yes, I modified the specfile to do that. I tracked it down to header ordering - in some cases config.h was being included after prefix.h which was redefining the relevant macros. I think it's fixed now - I guess prefix.h including config.h would fix that too.

As to -D flags vs config.h entries, well, I don't know enough about autoheader/autoconf to comment I'm afraid so I'll let Hongli deal with that.

Whoops, I'm not on the list, can you CC me on replies? :) Bryce forwarded me your response.

I have an updated patch that makes prefix.c C++ type-safe.

As for the config.h entries, I'd love to see where autoheader is considered deprecated. At least according to the documentation from autoconf 2.59, I see no mention of autoheader going away. Using "make" to detect changes in your build system won't pay attention to -D flags, but it will see changes in the config.h. With large packages (like inkscape), I don't want to have to do a full recompile.

Also, for the end user who is attempting to compile the program, they shouldn't have to know which files to delete or to do a "make clean" if they decide to change a "configure" option. I should be able to run "configure --disable-binreloc", "make", and then "configure --enable-binreloc", "make" and have things correctly rebuild. Without the config.h entries, this is not happening.

If people aren't using config.h, then they won't have an "AM_CONFIG_HEADER"/"AC_CONFIG_HEADER" call in their configure.ac, so my patch stands: for those using CFLAGS, it will work. For those using config.h it will work. And neither will step on the others' toes. :)