Request for Comments on an Idea - Rendering Tests
Hi all!
Do you think it would be a good idea to make Inkscape's test suite more comprehensive by making sure some (= as many as we can) input SVGs result in the same bitmap images after being rendered by --export-png? It won't be too hard to implement, and may prevent regressions.
Regards,
Shlomi Fish
Definitely! In my opinion regressions are one of Inkscape's largest weaknesses.
Also it would be a good idea to have more than just SVG files as input to check if import filters work as expected.
Last but not least those tests should be automated. I'm already looking forward to the move to GitHub where CI implementation should be easy(er) to implement an should be a priority.
Regards, Eduard
Am 12.06.2016 um 17:33 schrieb Shlomi Fish:
Hi all!
Do you think it would be a good idea to make Inkscape's test suite more comprehensive by making sure some (= as many as we can) input SVGs result in the same bitmap images after being rendered by --export-png? It won't be too hard to implement, and may prevent regressions.
Regards,
Shlomi Fish
On Sun, 2016-06-12 at 18:33 +0300, Shlomi Fish wrote:
Hi all!
Do you think it would be a good idea to make Inkscape's test suite more comprehensive by making sure some (= as many as we can) input SVGs result in the same bitmap images after being rendered by --export-png? It won't be too hard to implement, and may prevent regressions.
We already have a set of image based tests. At one point it was run automatically but maintaining it was a problem.
https://inkscape.org/en/contribute/testing/#rendering-tests
If we could get this working again, it would be great.
Tav
On Wed, 2016-06-15 at 18:09 +0200, Tavmjong Bah wrote:
On Sun, 2016-06-12 at 18:33 +0300, Shlomi Fish wrote:
Hi all!
Do you think it would be a good idea to make Inkscape's test suite more comprehensive by making sure some (= as many as we can) input SVGs result in the same bitmap images after being rendered by --export-png? It won't be too hard to implement, and may prevent regressions.
We already have a set of image based tests. At one point it was run automatically but maintaining it was a problem.
https://inkscape.org/en/contribute/testing/#rendering-tests
If we could get this working again, it would be great.
svn co https://svn.code.sf.net/p/inkscape/code/gsoc-testsuite
Hi Tavmjong and all,
On Wed, 15 Jun 2016 18:09:13 +0200 Tavmjong Bah <tavmjong@...8...> wrote:
On Sun, 2016-06-12 at 18:33 +0300, Shlomi Fish wrote:
Hi all!
Do you think it would be a good idea to make Inkscape's test suite more comprehensive by making sure some (= as many as we can) input SVGs result in the same bitmap images after being rendered by --export-png? It won't be too hard to implement, and may prevent regressions.
We already have a set of image based tests. At one point it was run automatically but maintaining it was a problem.
https://inkscape.org/en/contribute/testing/#rendering-tests
If we could get this working again, it would be great.
As noted on IRC, the information there is out-of-date because the repository was moved to bzr on launchpad. Furthermore, this is out-of-date as well:
* http://wiki.inkscape.org/wiki/index.php/Testing_Inkscape#Rendering_tests
Shouldn't it be updated? Should I file a bug about it?
Please reply as soon as possible.
Regards,
Shlomi Fish
On Sun, 2016-06-19 at 11:29 +0300, Shlomi Fish wrote:
Hi Tavmjong and all,
On Wed, 15 Jun 2016 18:09:13 +0200 Tavmjong Bah <tavmjong@...8...> wrote:
On Sun, 2016-06-12 at 18:33 +0300, Shlomi Fish wrote:
Hi all!
Do you think it would be a good idea to make Inkscape's test suite more comprehensive by making sure some (= as many as we can) input SVGs result in the same bitmap images after being rendered by --export-png? It won't be too hard to implement, and may prevent regressions.
We already have a set of image based tests. At one point it was run automatically but maintaining it was a problem.
https://inkscape.org/en/contribute/testing/#rendering-tests
If we could get this working again, it would be great.
As noted on IRC, the information there is out-of-date because the repository was moved to bzr on launchpad. Furthermore, this is out-of-date as well:
tests
Shouldn't it be updated? Should I file a bug about it?
Please reply as soon as possible.
Might be quicker to fix yourself rather than filing a bug about it. I can fix it but not for a week or so... got too many other things in the queue; on the way to an SVG working group meeting at the moment.
Tav
On Wed, Jun 15, 2016 at 06:09:13PM +0200, Tavmjong Bah wrote:
On Sun, 2016-06-12 at 18:33 +0300, Shlomi Fish wrote:
Hi all!
Do you think it would be a good idea to make Inkscape's test suite more comprehensive by making sure some (= as many as we can) input SVGs result in the same bitmap images after being rendered by --export-png? It won't be too hard to implement, and may prevent regressions.
We already have a set of image based tests. At one point it was run automatically but maintaining it was a problem.
https://inkscape.org/en/contribute/testing/#rendering-tests
If we could get this working again, it would be great.
Yep, maintenance is the trick with automated testsuites.
Creating the testsuite and automating it are usually straightforward one-time efforts, but it's for naught if it isn't coupled with someone dedicated to follow up on and/or fix issues the automated tests discover.
Bryce
participants (4)
-
Bryce Harrington -
Eduard Braun -
Shlomi Fish -
Tavmjong Bah