Johan E,
I've looked at the inkscape-rendertest branch.
There is a pdiff codebase and a few other bits, but I notice no use of Pillow(was PIL) to process the images. We have access to PIL.ImageChomp to select the difference rectangles and further processing (with some good guides online) for pulling out more information if we need to.
http://stackoverflow.com/questions/1927660/compare-two-images-the-python-lin...
If we went with pdiff instead of Chomp and CMP in python, was there a reason?
Thanks for your time.
Best Regards, Martin Owens
Johan,
Is the rendertests branch from when Tomasz had worked on it? Looking at his, there might be more tests there.
Cheers, Josh
On Wed, Nov 12, 2014 at 4:21 PM, Martin Owens <doctormo@...400...> wrote:
Johan E,
I've looked at the inkscape-rendertest branch.
There is a pdiff codebase and a few other bits, but I notice no use of Pillow(was PIL) to process the images. We have access to PIL.ImageChomp to select the difference rectangles and further processing (with some good guides online) for pulling out more information if we need to.
http://stackoverflow.com/questions/1927660/compare-two-images-the-python-lin...
If we went with pdiff instead of Chomp and CMP in python, was there a reason?
Thanks for your time.
Best Regards, Martin Owens
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.cl... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Hm, I was not aware of another rendertest branch. I just copied the rendertest repo that was still in SVN (made by Jasper for GSoC). If there is a more recent branch, we should start from that one. Where is it?
- Johan
On 13-11-2014 2:47, Josh Andler wrote:
Johan,
Is the rendertests branch from when Tomasz had worked on it? Looking at his, there might be more tests there.
Cheers, Josh
On Wed, Nov 12, 2014 at 4:21 PM, Martin Owens <doctormo@...400...> wrote:
Johan E,
I've looked at the inkscape-rendertest branch.
There is a pdiff codebase and a few other bits, but I notice no use of Pillow(was PIL) to process the images. We have access to PIL.ImageChomp to select the difference rectangles and further processing (with some good guides online) for pulling out more information if we need to.
http://stackoverflow.com/questions/1927660/compare-two-images-the-python-lin...
If we went with pdiff instead of Chomp and CMP in python, was there a reason?
Thanks for your time.
Best Regards, Martin Owens
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.cl... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.cl... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
There are two parts to the work Tomasz did if I'm not mistaken... one is the testsuite itself [1] and the other is the web portion of it [2] which I assume powered what I helped him review results [3] on.
[1] https://code.launchpad.net/~penginsbacon/+junk/inkscape-testsuite [2] https://code.launchpad.net/~penginsbacon/+junk/inkscape-testsuite-web [3] http://tboczkowski.linuxpl.info/svg_compliance/compliance/trunk
Cheers, Josh
On Thu, Nov 13, 2014 at 11:17 AM, Johan Engelen <jbc.engelen@...2592...> wrote:
Hm, I was not aware of another rendertest branch. I just copied the rendertest repo that was still in SVN (made by Jasper for GSoC). If there is a more recent branch, we should start from that one. Where is it?
- Johan
On 13-11-2014 2:47, Josh Andler wrote:
Johan,
Is the rendertests branch from when Tomasz had worked on it? Looking at his, there might be more tests there.
Cheers, Josh
On Wed, Nov 12, 2014 at 4:21 PM, Martin Owens <doctormo@...400...> wrote:
Johan E,
I've looked at the inkscape-rendertest branch.
There is a pdiff codebase and a few other bits, but I notice no use of Pillow(was PIL) to process the images. We have access to PIL.ImageChomp to select the difference rectangles and further processing (with some good guides online) for pulling out more information if we need to.
http://stackoverflow.com/questions/1927660/compare-two-images-the-python-lin...
If we went with pdiff instead of Chomp and CMP in python, was there a reason?
Thanks for your time.
Best Regards, Martin Owens
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.cl... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.cl... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.cl... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Wow, that's pretty great. Martin, we should work from there!
cheers, Johan
On 13-11-2014 20:31, Josh Andler wrote:
There are two parts to the work Tomasz did if I'm not mistaken... one is the testsuite itself [1] and the other is the web portion of it [2] which I assume powered what I helped him review results [3] on.
[1] https://code.launchpad.net/~penginsbacon/+junk/inkscape-testsuite [2] https://code.launchpad.net/~penginsbacon/+junk/inkscape-testsuite-web [3] http://tboczkowski.linuxpl.info/svg_compliance/compliance/trunk
Cheers, Josh
On Thu, Nov 13, 2014 at 11:17 AM, Johan Engelen <jbc.engelen@...2592...> wrote:
Hm, I was not aware of another rendertest branch. I just copied the rendertest repo that was still in SVN (made by Jasper for GSoC). If there is a more recent branch, we should start from that one. Where is it?
- Johan
On 13-11-2014 2:47, Josh Andler wrote:
Johan,
Is the rendertests branch from when Tomasz had worked on it? Looking at his, there might be more tests there.
Cheers, Josh
On Wed, Nov 12, 2014 at 4:21 PM, Martin Owens <doctormo@...400...> wrote:
Johan E,
I've looked at the inkscape-rendertest branch.
There is a pdiff codebase and a few other bits, but I notice no use of Pillow(was PIL) to process the images. We have access to PIL.ImageChomp to select the difference rectangles and further processing (with some good guides online) for pulling out more information if we need to.
http://stackoverflow.com/questions/1927660/compare-two-images-the-python-lin...
If we went with pdiff instead of Chomp and CMP in python, was there a reason?
Thanks for your time.
Best Regards, Martin Owens
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.cl... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.cl... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.cl... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 13-11-2014 1:21, Martin Owens wrote:
Johan E,
I've looked at the inkscape-rendertest branch.
There is a pdiff codebase and a few other bits, but I notice no use of Pillow(was PIL) to process the images. We have access to PIL.ImageChomp to select the difference rectangles and further processing (with some good guides online) for pulling out more information if we need to.
http://stackoverflow.com/questions/1927660/compare-two-images-the-python-lin...
If we went with pdiff instead of Chomp and CMP in python, was there a reason?
The original python script I believe could do a binary compare, or a perceptual compare (using perceptualdiff). No need to use perceptualdiff specifically. We do need a fuzzy-ness threshold, otherwise the compares will fail too often. Imagemagick seems to provide cool stuff there too...
You should be aware of the different types of compares we should do: - compare with pass-reference, if available (pass) - compare with fail-references, if avail (fail) - compare with patched svg file (that should render to what is intended) (pass)
Desirables for the tests: - XML output, parsable by xUnit Jenkins plugin. GoogleTest output is fine, CTest output, many other formats all using XML. - Timeout: if Inkscape takes too long, fail the test - Performance: add execution time to output (like GoogleTest does) - If ok: don't output too much - If not ok, different from pass reference: output difference picture, indicating the differences - If not ok, same as fail-ref: say that output is equal to fail ref
I can think of many other nice-to-haves, but let's get this working first. Most important thing is to get the tests running on the Jenkins server. It is easiest if the python script can be called, something like:
runtests.py --inkscape=/bla/bla/inkscape --XML=rendertest-results.xml (--options=optionsfile-that-is-stored-in-bzr?)
Thanks so much,
- Johan
participants (3)
-
Johan Engelen -
Josh Andler -
Martin Owens