Hi, I'm testing and debugging my translation on the inkscape-0.47pre2 version and I found the following: When I apply a filter to an object, say "Wrinkled varnish", the menu option appears correctly translated as "Barniz arrugado", but when I select the object, on the status bar I see the description of the object, for example:* "Elipse; **filtrado (Wrinkled varnish)* en capa* Capa 1*. Pulse......". As you see, the name of the filter does not appear translated here. I think it's this segment in the po file: the second "%s" is not getting the correct string. ============================ #: ../src/sp-item.cpp:1065 #, c-format msgid "%s; <i>filtered (%s)</i>" msgstr "%s; <i>filtrado (%s)</i>" ============================
Should I open a bug report?
Thanks,
On Thu, Sep 3, 2009 at 2:20 PM, Lucas Vieites wrote:
Hi, I'm testing and debugging my translation on the inkscape-0.47pre2 version and I found the following: When I apply a filter to an object, say "Wrinkled varnish", the menu option appears correctly translated as "Barniz arrugado", but when I select the object, on the status bar I see the description of the object, for example: "Elipse; filtrado (Wrinkled varnish) en capa Capa 1. Pulse......". As you see, the name of the filter does not appear translated here.
i18n is completely broken for filters. It's not the only issue really :(
Alexandre
On Thu, 2009-09-03 at 17:04 +0400, Alexandre Prokoudine wrote:
On Thu, Sep 3, 2009 at 2:20 PM, Lucas Vieites wrote:
Hi, I'm testing and debugging my translation on the inkscape-0.47pre2 version and I found the following: When I apply a filter to an object, say "Wrinkled varnish", the menu option appears correctly translated as "Barniz arrugado", but when I select the object, on the status bar I see the description of the object, for example: "Elipse; filtrado (Wrinkled varnish) en capa Capa 1. Pulse......". As you see, the name of the filter does not appear translated here.
i18n is completely broken for filters. It's not the only issue really :(
Are they filed as bugs? I mean, most i18n issues are pretty easy to fix because gettext does all the work. The patch to the original poster is probably as simple as this:
=== modified file 'src/sp-item.cpp' --- src/sp-item.cpp 2009-08-06 13:17:17 +0000 +++ src/sp-item.cpp 2009-09-03 13:42:27 +0000 @@ -1062,7 +1062,7 @@ const gchar *label = SP_OBJECT_STYLE(item)->filter.href->getObject()->label(); gchar *snew; if (label) { - snew = g_strdup_printf (_("%s; <i>filtered (%s)</i>"), s, label); + snew = g_strdup_printf (_("%s; <i>filtered (%s)</i>"), s, _(label)); } else { snew = g_strdup_printf (_("%s; <i>filtered</i>"), s); }
Literally a 3 character change.
--Ted
On Thu, Sep 3, 2009 at 9:44 AM, Ted Gould<ted@...11...> wrote:
Are they filed as bugs? I mean, most i18n issues are pretty easy to fix because gettext does all the work. The patch to the original poster is probably as simple as this:
Will someone please test this patch and if it works, commit it? I never touch the i18n system so feel free to commit to it if you're reasonably sure you know what you're doing :)
Hi,
Will someone please test this patch and if it works, commit it? I never touch the i18n system so feel free to commit to it if you're reasonably sure you know what you're doing :)
If someone commits it, may I ask him to drop a comment here (the bugreport this issue is reported in):
https://bugs.launchpad.net/inkscape/+bug/408093
Arpad Biro
Hi,
De : Arpad Biro <biro.arpad@...400...>
Will someone please test this patch and if it works, commit it? I never touch the i18n system so feel free to commit to it if you're reasonably sure you know what you're doing :)
If someone commits it, may I ask him to drop a comment here (the bugreport this issue is reported in):
I've tested this patch, which is working well. It'll be included in a mega-patch I'm working on. I send it as soon as possible. Probably in the next 24 hours. All comments are in the bug report.
Regards, -- Nicolas
De : Nicolas Dufour <nicoduf@...48...>
I've tested this patch, which is working well. It'll be included in a mega-patch I'm working on. I send it as soon as possible. Probably in the next 24 hours. All comments are in the bug report.
The patch is ready: https://bugs.launchpad.net/inkscape/+bug/408093
Please take a look a the src/extension/implementation/script.cpp fix. I had to add some c++ code (other than _()...), and this is not my native language ;). There's probably a better a simpler way to remove an extra \n at the end of a string.
Regards. -- Nicolas
participants (6)
-
Alexandre Prokoudine -
Arpad Biro -
bulia byak -
Lucas Vieites -
Nicolas Dufour -
Ted Gould