After a little investigation yesterday, I think that the style test is failing when trying to set "font-size" to "0". I think that after it goes through all the style code it comes out as "0px". Is this correct? Is this a problem with the test?
--Ted
After a little investigation yesterday, I think that the style test is failing when trying to set "font-size" to "0". I think that after it goes through all the style code it comes out as "0px". Is this correct? Is this a problem with the test?
Ah, I was thinking it was probably my fault when I read your previous e-mail and was going to investigate, but you're too quick for me. It's definitely my fault.
This was the fix for https://sourceforge.net/tracker/index.php?func=detail&aid=1221626&gr... which is a compatibility tweak so that Mozilla can render fonts at the correct size. Technically we shouldn't have to do this, but reading the Bugzilla entry convinced me that the SVG spec has made life extremely difficult for them and that compatibility with Mozilla is sufficiently important for us that making this change was a good idea.
Richard.
Richard Hughes wrote:
After a little investigation yesterday, I think that the style test is failing when trying to set "font-size" to "0". I think that after it goes through all the style code it comes out as "0px". Is this correct? Is this a problem with the test?
Ah, I was thinking it was probably my fault when I read your previous e-mail and was going to investigate, but you're too quick for me. It's definitely my fault.
This was the fix for https://sourceforge.net/tracker/index.php?func=detail&aid=1221626&gr... which is a compatibility tweak so that Mozilla can render fonts at the correct size. Technically we shouldn't have to do this, but reading the Bugzilla entry convinced me that the SVG spec has made life extremely difficult for them and that compatibility with Mozilla is sufficiently important for us that making this change was a good idea.
Good, I like it when there are reasons for tests failing ;)
Peter, do you have a way that you want to change style-test.cpp to adjust for this? Take 'font-size' out for the list for now?
--Ted
participants (2)
-
Richard Hughes -
Ted Gould